Page MenuHomePhabricator
Differential D14933

Move various other callsites away from callsigns
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 8:24 PM.
Tags
None
Referenced Files
F19087361: D14933.id36085.diff
Dec 3 2025, 12:19 AM
F19087360: D14933.id36076.diff
Dec 3 2025, 12:19 AM
F19087359: D14933.id.diff
Dec 3 2025, 12:19 AM
F19080247: D14933.diff
Dec 2 2025, 12:27 AM
F19074051: D14933.id36076.diff
Dec 1 2025, 4:08 AM
F18832153: D14933.diff
Oct 25 2025, 7:41 PM
F18783383: D14933.id.diff
Oct 13 2025, 6:19 AM
F18654302: D14933.id36076.diff
Sep 22 2025, 5:58 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPbcfd6bdd81ee: Move various other callsites away from callsigns
Summary

Ref T4245. These mostly relate to building URIs.

Test Plan

Tried to hunt down as many of these in the UI as I could. Some are a bit tricky but they should be low-risk.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36076.Jan 2 2016, 8:24 PM
epriestley retitled this revision from to Move various other callsites away from callsigns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 3 2016, 4:53 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 3 2016, 4:53 AM
Closed by commit rPbcfd6bdd81ee: Move various other callsites away from callsigns (authored by epriestley, committed by epriestley). · Explain WhyJan 4 2016, 2:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36085

View Options

src/applications/diffusion/controller/DiffusionChangeController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionExternalController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitBranchesHeraldField.php

Loading...
View Options

src/applications/diffusion/query/DiffusionQuery.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitBranchesField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitMergedCommitsField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitTagsField.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility