Page MenuHomePhabricator
Differential D14927

Remove various additional calls to getCallsign()
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 2:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:37 AM
Unknown Object (File)
Wed, Apr 10, 11:54 PM
Unknown Object (File)
Mon, Apr 8, 1:41 AM
Unknown Object (File)
Tue, Apr 2, 4:27 PM
Unknown Object (File)
Tue, Mar 26, 12:26 PM
Unknown Object (File)
Sat, Mar 23, 5:44 PM
Unknown Object (File)
Sat, Mar 23, 5:44 PM
Unknown Object (File)
Sat, Mar 23, 5:44 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rP37532a0bf001: Remove various additional calls to getCallsign()
Summary

Ref T4245. These are all straightforward to remove.

Test Plan
  • Edited paths in a package.
  • Ran bin/audit delete --repositories ... with various identifiers.
  • Searched by repository for R3, rAAAA in Harbormaster.
  • Did a Herald dry run on a commit.
  • Browsed commits, made comments.
  • Viewed a Releeph product list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36066.Jan 2 2016, 2:19 PM
epriestley retitled this revision from to Remove various additional calls to getCallsign().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 2 2016, 4:12 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2016, 4:12 PM
Closed by commit rP37532a0bf001: Remove various additional calls to getCallsign() (authored by epriestley, committed by epriestley). · Explain WhyJan 2 2016, 7:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
2 lines
management/
21 lines
diffusion/
herald/
5 lines
harbormaster/
query/
2 lines
owners/
controller/
2 lines
releeph/
controller/
product/
6 lines
differential/
2 lines
query/
4 lines

Diff 36069

View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...
View Options

src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php

Loading...
View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersPathsController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductCreateController.php

Loading...
View Options

src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php

Loading...
View Options

src/applications/releeph/query/ReleephProductSearchEngine.php

Loading...
Phabricator · Built by Phacility