Page MenuHomePhabricator

Begin modularizing main menu items
ClosedPublic

Authored by epriestley on Jan 1 2016, 1:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 3:16 PM
Unknown Object (File)
Thu, Dec 12, 1:34 AM
Unknown Object (File)
Sun, Dec 8, 6:03 AM
Unknown Object (File)
Sun, Dec 8, 12:54 AM
Unknown Object (File)
Wed, Dec 4, 6:23 AM
Unknown Object (File)
Fri, Nov 29, 7:51 PM
Unknown Object (File)
Nov 4 2024, 2:49 PM
Unknown Object (File)
Nov 4 2024, 2:19 PM
Subscribers
None

Details

Summary

Ref T10077. Ref T8918. The way the main menu is built is not very modular and fairly hacky.

It assumes menus are provided by applications, but this isn't exactly true. Notably, the "Quick Create" menu is not per-application.

The current method of building this menu is very inefficient (see T10077). Particularly, we have to build it twice because we need to build it once to render the item and then again to render the dropdown options.

Start cleaning this up. This diff doesn't actually have any behavioral changes, since I can't swap the menu over until we get rid of all the other items and I haven't extended this to Notifications/Conpherence yet so it doesn't actually fix T8918.

Test Plan

Viewed menus while logged in, logged out, in different applications, in desktop/mobile. Nothing appeared different.

Diff Detail

Repository
rP Phabricator
Branch
menu1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9879
Build 11908: Run Core Tests
Build 11907: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Begin modularizing main menu items.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 1 2016, 4:16 PM
This revision was automatically updated to reflect the committed changes.