Creates a new next/previous UI for PhamePosts, and adds a setFoot to PHUIDocumentViewPro for future use in other apps.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rPfe6224f5059e: Add Next and Previous UI to PhamePostView
Test first, next, last posts on Phame in mobile, desktop, and tablet breakpoints.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phame-next (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 9873 Build 11898: Run Core Tests Build 11897: arc lint + arc unit
Event Timeline
Comment Actions
executeOne() will cause us to throw a policy exception if the first matching object isn't visible to the viewer. Repro instructions should be:
- Create posts A and B on a blog.
- Hide post A so you can't see it.
- View post B.
- Policy exception from executeOne().
You should still use execute(); you can pick the first item out with head(...).
| src/applications/phame/controller/post/PhamePostViewController.php | ||
|---|---|---|
| 259–263 | These two execute() -> executeOne() changes, particularly. | |