Page MenuHomePhabricator

Allow installs to customize project icons
ClosedPublic

Authored by epriestley on Dec 31 2015, 3:11 PM.
Tags
None
Referenced Files
F13082902: D14918.diff
Wed, Apr 24, 10:20 PM
Unknown Object (File)
Fri, Apr 19, 4:00 PM
Unknown Object (File)
Thu, Apr 11, 5:11 AM
Unknown Object (File)
Tue, Apr 9, 9:51 PM
Unknown Object (File)
Sat, Apr 6, 11:29 AM
Unknown Object (File)
Mar 24 2024, 2:05 PM
Unknown Object (File)
Mar 23 2024, 12:28 AM
Unknown Object (File)
Mar 22 2024, 8:21 PM
Tokens
"Love" token, awarded by 20after4.

Details

Summary

Ref T10010. Ref T5819. General alignment of the stars:

  • There were some hacks in Conduit around stripping fa-... off icons when reading and writing that I wanted to get rid of.
  • We probably have room for a subtitle in the new heavy nav, and using the icon name is a good starting point (and maybe good enough on its own?)
  • The project list was real bad looking with redundant tag/names, now it is very slightly less bad looking with non-redundant types?
  • Some installs will want to call Milestones something else, and this gets us a big part of the way there.
  • This may slightly help to reinforce "tag" vs "policy" vs "group" stuff?

I'm letting installs have enough rope to shoot themselves in the foot (e.g., define 100 icons). It isn't the end of the world if they reuse icons, and is clearly their fault.

I think the cases where 100 icons will break down are:

  • Icon selector dialog may get very unwieldy.
  • Query UI will be pretty iffy/huge with 100 icons.

We could improve these fairly easily if an install comes up with a reasonable use case for having 100 icons.


The UI on the icon itself in the list views is a little iffy -- mostly, it's too saturated/bold.

I'd ideally like to try either:

  • rendering a "shade" version (i.e. lighter, less-saturated color); or
  • rendering a "shade" tag with just the icon in it.

However, there didn't seem to be a way to do the first one right now (fa-example sh-blue doesn't work) and the second one had weird margins/padding, so I left it like this for now. I figure we can clean it up once we build the thick nav, since that will probably also want an identical element.

(I don't want to render a full tag with the icon + name since I think that's confusing -- it looks like a project/object tag, but is not.)

Test Plan

Screen Shot 2015-12-31 at 7.01.07 AM.png (753×1 px, 126 KB)

Screen Shot 2015-12-31 at 7.01.18 AM.png (753×1 px, 103 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow installs to customize project icons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Oh, there's one more design change:

Screen Shot 2015-12-31 at 7.12.38 AM.png (339×552 px, 18 KB)

I gave the selected icon a stronger border because the difference in background color was so mild that I could barely pick out which one was selected (at least, on my monitor).

epriestley edited edge metadata.
  • Don't show disabled icons in the ApplicationSearch query UI either (this probably helps motivate eventually converting this to a typeahead).

So a admin can choose the icons which the users can choose for projects?

My rough idea was whatever UI ends up in the sidenav, that it also become the list view as well, sort of like a small pinboard (sans tab links). I'm not entirely sure this will work, I just need a few hours alone in Photoshop.

chad edited edge metadata.

the only oddness I can think of is checkered won't have an icon. But "project list UI" is something I do want to revisit soon

src/applications/project/phid/PhabricatorProjectProjectPHIDType.php
54

lul

This revision is now accepted and ready to land.Jan 1 2016, 4:10 PM

Yeah, ...IconIcon() is a little goofy but I wanted it to be explicit since Icon could mean the Icon object or the font-icons thing.

@20after4, this might impact whatever IRC-like bot you have set up in T6501 -- I'll write up some guidance around the time this lands and CC you. (Shouldn't be a big deal, and you'd have to update the bot anyway if you're planning to add more icons.)

I'm going to kick this in since I'm pretty sure the technical side of it is compatible with planned changes. List view is definitely a bit funky with this patch, but that'll get cleaned up once we're further along, and it's a bit weird as-is anyway.

This revision was automatically updated to reflect the committed changes.

Haha, I didn't even realize how silly this is:

Screen Shot 2016-01-08 at 2.03.56 PM.png (250×304 px, 23 KB)