Page MenuHomePhabricator

Lock milestone projects to an automatic color/icon

Authored by epriestley on Dec 30 2015, 11:48 AM.
Referenced Files
F11404970: D14912.diff
Thu, Dec 1, 7:32 PM
Unknown Object (File)
Tue, Nov 29, 8:08 PM
Unknown Object (File)
Tue, Nov 29, 8:08 PM
Unknown Object (File)
Tue, Nov 29, 8:08 PM
Unknown Object (File)
Fri, Nov 25, 2:58 AM
Unknown Object (File)
Wed, Nov 16, 6:54 AM
Unknown Object (File)
Thu, Nov 10, 10:13 PM
Unknown Object (File)
Thu, Nov 10, 3:05 AM
"Like" token, awarded by Luke081515.2.



Ref T10010.

Currently, milestone subproject have editable icons/colors, but I don't think this is likely to be used much (the expectation is that milestones will be common and homogenous, and it doesn't make much sense to pick different icons for "Sprint 32" vs "Sprint 33", I think).

Locking the icon and color lets us simplify the form, make milestones more distinct, and potentially reuse the color later for other things (e.g., active/future/past or on time / overdue or whatever else) or just give them a special color to make them more visible.

The best argument for retaining this that I can come up with is that certain milestones may be special (e.g., Sprint 19 is a major release?), but you can just name it "Sprint 19 (v3.0!)" or something, which seems pretty good for now.

Also don't show milestones on task browse/list view.

Test Plan

Screen Shot 2015-12-30 at 3.45.58 AM.png (298×284 px, 23 KB)

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 9860
Build 11879: Run Core Tests
Build 11878: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Lock milestone projects to an automatic color/icon.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

wonder if we should have a non-briefcase default image for these

This revision is now accepted and ready to land.Dec 30 2015, 5:09 PM

If we ever use it for anything, we can do a migration. Next diff changes this stuff a bit, too.

This revision was automatically updated to reflect the committed changes.