Page MenuHomePhabricator

Make queries for Project "X" mean "X, or any subproject of X"
ClosedPublic

Authored by epriestley on Dec 29 2015, 2:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 29, 8:17 PM
Unknown Object (File)
Tue, Nov 29, 8:17 PM
Unknown Object (File)
Tue, Nov 29, 8:17 PM
Unknown Object (File)
Wed, Nov 16, 7:00 AM
Unknown Object (File)
Wed, Nov 16, 1:01 AM
Unknown Object (File)
Tue, Nov 15, 9:08 AM
Unknown Object (File)
Mon, Nov 14, 3:34 AM
Unknown Object (File)
Thu, Nov 10, 3:05 AM
Subscribers
None

Details

Summary

Ref T10010. I think this is the desired/expected default behavior (e.g., searching for "Maniphest" should find tasks in any subproject or sprint of that project).

I'll probably add an "exact(...)" function later to mean "only the Maniphest superproject, exactly, not any of its children".

Test Plan
  • Added and executed unit tests.
  • Ran various queries from the web UI.
  • Got sensible-seeming results.

Diff Detail

Repository
rP Phabricator
Branch
sub11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9854
Build 11871: Run Core Tests
Build 11870: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make queries for Project "X" mean "X, and any subproject of X".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley retitled this revision from Make queries for Project "X" mean "X, and any subproject of X" to Make queries for Project "X" mean "X, or any subproject of X".Dec 29 2015, 3:02 PM
epriestley updated this object.

them test cases got me like

itsawesome

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2015, 5:04 PM
This revision was automatically updated to reflect the committed changes.