Page MenuHomePhabricator

Smooth out milestone creation workflow
ClosedPublic

Authored by epriestley on Dec 29 2015, 12:45 PM.
Tags
None
Referenced Files
F13087842: D14909.diff
Thu, Apr 25, 1:07 AM
F13084855: D14909.diff
Wed, Apr 24, 11:28 PM
Unknown Object (File)
Fri, Apr 19, 3:59 PM
Unknown Object (File)
Wed, Apr 10, 7:53 PM
Unknown Object (File)
Sun, Apr 7, 10:07 AM
Unknown Object (File)
Sat, Apr 6, 6:07 PM
Unknown Object (File)
Mon, Apr 1, 6:31 AM
Unknown Object (File)
Mon, Apr 1, 12:25 AM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rP70053beeed60: Smooth out milestone creation workflow
Summary

Ref T10010.

  • Default name to "Milestone X".
  • Remove policy controls, which have no effect.
  • Don't generate slugs for milestones since this is a big pain where they all generate as #milestone_1 by default (you can add one if you want). I plan to add some kind of syntax like #parent/32 to mean "Milestone 32 in Parent" later.
  • Don't require projects to have unique names (again, 900 copies of "Milestone X"). I think we can trust users to sort this out for themselves since modern Phabricator has "Can Create Projects" permission, etc.
Test Plan

Created some milestones, had a less awful experience.

Diff Detail

Repository
rP Phabricator
Branch
sub10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9853
Build 11869: Run Core Tests
Build 11868: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Smooth out milestone creation workflow.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2015, 5:00 PM
This revision was automatically updated to reflect the committed changes.