Fix bad query on PhameHome with no Blogs
ClosedPublic
Actions

Authored by chad on Dec 29 2015, 7:11 AM.

Tags

None

Referenced Files

	F15466115: D14908.diff
	Thu, Apr 3, 1:45 AM

	F15457316: D14908.diff
	Sun, Mar 30, 3:35 PM

	F15420715: D14908.id36032.diff
	Fri, Mar 21, 4:16 PM

	F15415118: D14908.id36029.diff
	Thu, Mar 20, 4:09 AM

	F15407920: D14908.id36029.diff
	Tue, Mar 18, 8:15 PM

	F15385378: D14908.id36029.diff
	Fri, Mar 14, 10:26 PM

	F15382280: D14908.diff
	Fri, Mar 14, 11:39 AM

	F15360386: D14908.diff
	Tue, Mar 11, 8:23 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP7732f9c03c84: Fix bad query on PhameHome with no Blogs

Summary

We're checking for drafts even though we already know there are no blogs, just skip the query.

Test Plan

trucate phame_blogs; See proper blank state.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36029.Dec 29 2015, 7:11 AM

chad retitled this revision from to Fix bad query on PhameHome with no Blogs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 29 2015, 7:11 AM

epriestley accepted this revision.Dec 29 2015, 11:08 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 29 2015, 11:08 AM

Closed by commit rP7732f9c03c84: Fix bad query on PhameHome with no Blogs (authored by chad, committed by chad). · Explain WhyDec 29 2015, 3:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

PhameHomeController.php

2 lines

Diff 36032

View Options

src/applications/phame/controller/PhameHomeController.php

Fix bad query on PhameHome with no BlogsClosedPublicActions