Differential D14904

Add very basic UI for creating milestones and subprojects
ClosedPublic
Actions

Authored by epriestley on Dec 28 2015, 8:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 1:26 PM

	Unknown Object (File)
	Tue, Dec 3, 10:01 AM

	Unknown Object (File)
	Sat, Nov 30, 8:08 PM

	Unknown Object (File)
	Fri, Nov 29, 6:46 PM

	Unknown Object (File)
	Fri, Nov 29, 6:45 PM

	Unknown Object (File)
	Fri, Nov 29, 6:45 PM

	Unknown Object (File)
	Thu, Nov 28, 8:50 PM

	Unknown Object (File)
	Tue, Nov 26, 9:53 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10010: Implement Subprojects

Commits

Restricted Diffusion Commit
rP7c5ad63fd1d6: Add very basic UI for creating milestones and subprojects

Summary

Ref T10010. This has a lot of UI/UX problems but I think it:

technically allows subproject creation;
technically allows milestone creation;
doesn't let users unwittingly destroy their installs (probably).

Test Plan

Created milestones.
Created subprojects.
Created and edited normal projects.
Observed some reasonable interactions (e.g., you can't create milestones for a milestone or edit a superproject's members).
Observed plenty of silly/confusing interactions that need additional work.

Screen Shot 2015-12-28 at 12.46.14 PM.png (767×1 px, 125 KB)

Screen Shot 2015-12-28 at 12.46.17 PM.png (767×1 px, 123 KB)

Screen Shot 2015-12-28 at 12.46.19 PM.png (767×1 px, 112 KB)

Screen Shot 2015-12-28 at 12.46.32 PM.png (767×1 px, 110 KB)

Screen Shot 2015-12-28 at 12.46.46 PM.png (767×1 px, 102 KB)

Diff Detail

Repository

Branch

sub9

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/project/editor/PhabricatorProjectTransactionEditor.php:734	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 9846
Build 11857: Run Core Tests
Build 11856: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36023.Dec 28 2015, 8:53 PM

epriestley retitled this revision from to Add very basic UI for creating milestones and subprojects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10010: Implement Subprojects.

Herald edited edge metadata. · View Herald TranscriptDec 28 2015, 8:53 PM

chad accepted this revision.Dec 29 2015, 4:12 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 29 2015, 4:12 PM

Closed by commit rP7c5ad63fd1d6: Add very basic UI for creating milestones and subprojects (authored by epriestley, committed by epriestley). · Explain WhyDec 29 2015, 6:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

__phutil_library_map__.php

2 lines

applications/

project/

__tests__/

PhabricatorProjectCoreTestCase.php

18 lines

controller/

PhabricatorProjectController.php

29 lines

PhabricatorProjectEditController.php

107 lines

PhabricatorProjectMembersEditController.php

4 lines

PhabricatorProjectMilestonesController.php

61 lines

PhabricatorProjectSubprojectsController.php

60 lines

editor/

PhabricatorProjectTransactionEditor.php

160 lines

engine/

PhabricatorProjectEditEngine.php

84 lines

query/

PhabricatorProjectSearchEngine.php

41 lines

storage/

PhabricatorProject.php

38 lines

view/

PhabricatorProjectListView.php

53 lines

webroot/

rsrc/

css/

layout/

phabricator-side-menu-view.css

4 lines

Diff 36023

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/project/tests/PhabricatorProjectCoreTestCase.php

Loading...

src/applications/project/controller/PhabricatorProjectController.php

Loading...

src/applications/project/controller/PhabricatorProjectEditController.php

Loading...

src/applications/project/controller/PhabricatorProjectMembersEditController.php

Loading...

src/applications/project/controller/PhabricatorProjectMilestonesController.php

Loading...

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/project/engine/PhabricatorProjectEditEngine.php

Loading...

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...

src/applications/project/view/PhabricatorProjectListView.php

Loading...

webroot/rsrc/css/layout/phabricator-side-menu-view.css

Loading...