Page MenuHomePhabricator
Differential D14902

Provide phame.post.edit Conduit API method
ClosedPublic
Actions

Authored by epriestley on Dec 28 2015, 2:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 8:27 AM
Unknown Object (File)
Mon, Jan 27, 3:14 AM
Unknown Object (File)
Fri, Jan 24, 10:50 AM
Unknown Object (File)
Sun, Jan 19, 9:28 AM
Unknown Object (File)
Sat, Jan 18, 5:15 AM
Unknown Object (File)
Sat, Jan 18, 12:13 AM
Unknown Object (File)
Fri, Jan 10, 5:47 AM
Unknown Object (File)
Jan 3 2025, 12:33 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9897: Unbeta Feedback on Phame
Commits
Restricted Diffusion Commit
rPe0a97c88dbec: Provide phame.post.edit Conduit API method
Summary

Ref T9897. This one is a little more involved because of how getting a post on a blog works.

I also changed moving posts to be a real transaction (which shows up in history, now).

Test Plan

Created posts from web UI and conduit.

Diff Detail

Repository
rP Phabricator
Branch
phame5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9838
Build 11847: Run Core Tests
Build 11846: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36015.Dec 28 2015, 2:21 PM
epriestley retitled this revision from to Provide phame.post.edit Conduit API method.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9897: Unbeta Feedback on Phame.
chad accepted this revision.Dec 28 2015, 2:46 PM
chad edited edge metadata.

itsbeautiful

This revision is now accepted and ready to land.Dec 28 2015, 2:46 PM
chad accepted this revision.Dec 28 2015, 2:48 PM
Closed by commit rPe0a97c88dbec: Provide phame.post.edit Conduit API method (authored by epriestley, committed by epriestley). · Explain WhyDec 28 2015, 2:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
conduit/
parametertype/
2 lines
phame/
conduit/
18 lines
controller/
post/
28 lines
52 lines
editor/
24 lines
54 lines
storage/
40 lines
transactions/
editengine/
11 lines
editfield/
6 lines

Diff 36015

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitPHIDParameterType.php

Loading...
View Options

src/applications/phame/conduit/PhamePostEditConduitAPIMethod.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostEditController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostMoveController.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditEngine.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/storage/PhamePostTransaction.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorPHIDListEditField.php

Loading...
Phabricator · Built by Phacility