Page MenuHomePhabricator
Differential D14897

Add Herald Adapters to Phame
ClosedPublic
Actions

Authored by chad on Dec 28 2015, 2:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 9:19 PM
Unknown Object (File)
Fri, Dec 13, 8:30 PM
Unknown Object (File)
Mon, Dec 9, 2:10 PM
Unknown Object (File)
Tue, Dec 3, 11:41 PM
Unknown Object (File)
Sun, Dec 1, 7:27 PM
Unknown Object (File)
Sun, Dec 1, 7:27 PM
Unknown Object (File)
Thu, Nov 28, 1:12 PM
Unknown Object (File)
Thu, Nov 28, 1:12 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP744215d5ffe4: Add Herald Adapters to Phame
Summary

Adds a basic HeraldAdapter to Phame Blogs and Posts.

Test Plan

Make a Herald rule to CC me on new posts or blogs automatically.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36008.Dec 28 2015, 2:05 AM
chad retitled this revision from to Add Herald Adapters to Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 28 2015, 2:05 AM
chad added inline comments.Dec 28 2015, 2:10 AM
src/applications/phame/herald/HeraldPhameBlogAdapter.php
60

I made these up?

chad updated this revision to Diff 36009.Dec 28 2015, 4:20 AM
  • more corrector
chad updated this object.Dec 28 2015, 4:21 AM
chad edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Jan 1 2016, 11:39 AM
epriestley edited edge metadata.

The getHeraldName() stuff just shows up on the "Transcripts" view, I think, and should be human-readable.

This revision is now accepted and ready to land.Jan 1 2016, 11:39 AM
chad updated this object.Jan 2 2016, 5:51 AM
chad edited edge metadata.
Closed by commit rP744215d5ffe4: Add Herald Adapters to Phame (authored by chad, committed by chad). · Explain WhyJan 5 2016, 10:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
phame/
editor/
14 lines
14 lines
herald/
62 lines
62 lines

Diff 36128

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditor.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/herald/HeraldPhameBlogAdapter.php

Loading...
View Options

src/applications/phame/herald/HeraldPhamePostAdapter.php

Loading...
Phabricator · Built by Phacility