Page MenuHomePhabricator
Differential D14890

Simplify some logic in project controllers
ClosedPublic
Actions

Authored by epriestley on Dec 27 2015, 11:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 10:47 AM
Unknown Object (File)
Thu, Dec 5, 10:12 AM
Unknown Object (File)
Tue, Dec 3, 5:05 PM
Unknown Object (File)
Mon, Dec 2, 10:40 PM
Unknown Object (File)
Thu, Nov 28, 10:09 PM
Unknown Object (File)
Wed, Nov 27, 6:31 AM
Unknown Object (File)
Tue, Nov 26, 10:23 PM
Unknown Object (File)
Sun, Nov 24, 7:47 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rP5e715c1acac0: Simplify some logic in project controllers
Summary

Ref T10010. Several controlers currently have similar logic for handling tags and slugs, loading projects, and canonicalizing URIs. Clean it up a bit.

Test Plan
  • Visited profile, boards, feed.
  • Visited by ID and by tag.
  • Visited by non-normal tag (redircted).
  • Visited by alternate tag (redirected).
  • Visited non-policy project by non-normal tag (redirected into policy error).

Diff Detail

Repository
rP Phabricator
Branch
sub3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9810
Build 11803: Run Core Tests
Build 11802: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35987.Dec 27 2015, 11:03 AM
epriestley retitled this revision from to Simplify some logic in project controllers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10010: Implement Subprojects.
chad accepted this revision.Dec 27 2015, 3:22 PM
chad edited edge metadata.

itsawesome

This revision is now accepted and ready to land.Dec 27 2015, 3:22 PM
Closed by commit rP5e715c1acac0: Simplify some logic in project controllers (authored by epriestley, committed by epriestley). · Explain WhyDec 27 2015, 5:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35987

View Options

src/applications/project/controller/PhabricatorProjectController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectFeedController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMembersEditController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectViewController.php

Loading...
Phabricator · Built by Phacility