Page MenuHomePhabricator

Simplify some logic in project controllers
ClosedPublic

Authored by epriestley on Dec 27 2015, 11:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 1, 4:54 AM
Unknown Object (File)
Tue, Nov 29, 8:15 PM
Unknown Object (File)
Tue, Nov 29, 8:15 PM
Unknown Object (File)
Tue, Nov 29, 8:15 PM
Unknown Object (File)
Wed, Nov 16, 6:58 AM
Unknown Object (File)
Fri, Nov 11, 1:39 PM
Unknown Object (File)
Thu, Nov 10, 5:58 AM
Unknown Object (File)
Thu, Nov 10, 3:00 AM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rP5e715c1acac0: Simplify some logic in project controllers
Summary

Ref T10010. Several controlers currently have similar logic for handling tags and slugs, loading projects, and canonicalizing URIs. Clean it up a bit.

Test Plan
  • Visited profile, boards, feed.
  • Visited by ID and by tag.
  • Visited by non-normal tag (redircted).
  • Visited by alternate tag (redirected).
  • Visited non-policy project by non-normal tag (redirected into policy error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Simplify some logic in project controllers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Dec 27 2015, 3:22 PM
This revision was automatically updated to reflect the committed changes.