Page MenuHomePhabricator

Implement a "Project Members" object policy rule
ClosedPublic

Authored by epriestley on Dec 24 2015, 1:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 12:15 PM
Unknown Object (File)
Tue, Aug 11, 8:35 AM
Unknown Object (File)
Sun, Aug 9, 12:38 PM
Unknown Object (File)
Sun, Aug 9, 11:28 AM
Unknown Object (File)
Jul 10 2026, 11:00 PM
Unknown Object (File)
Jul 4 2026, 12:28 AM
Unknown Object (File)
Jun 30 2026, 12:31 AM
Unknown Object (File)
Jun 22 2026, 5:29 PM
Subscribers
None

Details

Summary

Fixes T9019. Pretty much ripped from D14467. I added the "policy hint" stuff so that you can create a project with this policy immediately.

I really dislike how the "hint" code works, but we almost never need to use it and the badness feels fairly well-contained.

Also pick up a quick feedback fix from D14863.

Test Plan
  • Added test coverage, got it to pass.
  • Created a project with "Visible To: Project Members".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a "Project Members" object policy rule.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 3:27 PM
This revision was automatically updated to reflect the committed changes.