Page MenuHomePhabricator

Implement a "Project Members" object policy rule
ClosedPublic

Authored by epriestley on Dec 24 2015, 1:19 AM.
Tags
None
Referenced Files
F15517344: D14869.id35944.diff
Sat, Apr 19, 2:15 AM
F15479846: D14869.id35956.diff
Tue, Apr 8, 9:45 AM
F15473078: D14869.diff
Sat, Apr 5, 7:26 PM
F15459172: D14869.id35956.diff
Mon, Mar 31, 10:32 AM
F15436126: D14869.id.diff
Mar 25 2025, 12:05 PM
F15429754: D14869.diff
Mar 24 2025, 4:06 AM
F15418731: D14869.id.diff
Mar 21 2025, 1:07 AM
F15389947: D14869.id.diff
Mar 15 2025, 5:47 AM
Subscribers
None

Details

Summary

Fixes T9019. Pretty much ripped from D14467. I added the "policy hint" stuff so that you can create a project with this policy immediately.

I really dislike how the "hint" code works, but we almost never need to use it and the badness feels fairly well-contained.

Also pick up a quick feedback fix from D14863.

Test Plan
  • Added test coverage, got it to pass.
  • Created a project with "Visible To: Project Members".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a "Project Members" object policy rule.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 3:27 PM
This revision was automatically updated to reflect the committed changes.