Page MenuHomePhabricator

Implement a "Project Members" object policy rule
ClosedPublic

Authored by epriestley on Dec 24 2015, 1:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 29, 8:29 PM
Unknown Object (File)
Thu, Nov 10, 2:53 AM
Unknown Object (File)
Oct 29 2022, 8:19 AM
Unknown Object (File)
Oct 28 2022, 5:36 PM
Unknown Object (File)
Oct 28 2022, 9:03 AM
Unknown Object (File)
Oct 28 2022, 1:06 AM
Unknown Object (File)
Sep 25 2022, 8:24 PM
Unknown Object (File)
Sep 20 2022, 5:14 PM
Subscribers
None

Details

Summary

Fixes T9019. Pretty much ripped from D14467. I added the "policy hint" stuff so that you can create a project with this policy immediately.

I really dislike how the "hint" code works, but we almost never need to use it and the badness feels fairly well-contained.

Also pick up a quick feedback fix from D14863.

Test Plan
  • Added test coverage, got it to pass.
  • Created a project with "Visible To: Project Members".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a "Project Members" object policy rule.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 3:27 PM
This revision was automatically updated to reflect the committed changes.