Trivial fixes from D14467
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 12:31 AM.

Tags

None

Referenced Files

	F18818255: D14868.id.diff
	Oct 21 2025, 10:41 PM

	F18811930: D14868.diff
	Oct 20 2025, 5:53 AM

	F18743792: D14868.id.diff
	Oct 3 2025, 12:52 AM

	F18704011: D14868.id35943.diff
	Sep 28 2025, 5:54 AM

	F18628519: D14868.diff
	Sep 16 2025, 6:30 AM

	F18598239: D14868.diff
	Sep 13 2025, 4:39 AM

	F18574506: D14868.diff
	Sep 10 2025, 10:54 AM

	F18551494: D14868.diff
	Sep 8 2025, 12:27 PM

View All Files

Subscribers

None

Details

Reviewers

joshuaspence
chad

Commits

Restricted Diffusion Commit
rPdc5397b2db5d: Trivial fixes from D14467

Summary

See D14467. Just teasing this apart so I can be a little more confident in my commandeering. These are the unambiguous cleanup changes from D14467.

Test Plan

inspection / clicked stuff / no impact

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35943.Dec 24 2015, 12:31 AM

epriestley retitled this revision from to Trivial fixes from D14467.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, chad.

joshuaspence accepted this revision.Dec 24 2015, 12:32 AM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Dec 24 2015, 12:32 AM

Closed by commit rPdc5397b2db5d: Trivial fixes from D14467 (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 1:19 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D14467: Add a "members of project" policy rule.Dec 24 2015, 1:21 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

policy/

rule/

PhabricatorPolicyRule.php

19 lines

project/

controller/

PhabricatorProjectProfileController.php

3 lines

Diff 35945

View Options

src/applications/policy/rule/PhabricatorPolicyRule.php