Page MenuHomePhabricator

Put inline previews in remarkup textareas
ClosedPublic

Authored by epriestley on Dec 22 2015, 8:09 PM.

Details

Summary

Ref T3967. This gives us a reasonable baseline for doing remarkup previews inline in all contexts, and works in weird/constrained context including:

  • inline comments;
  • conpherence; and
  • custom fields.

It would be nicer to go beyond this in contexts like Phame posts, but this is a start, at least.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 35910.Dec 22 2015, 8:09 PM
epriestley retitled this revision from to Put inline previews in remarkup textareas.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Dec 22 2015, 8:17 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2015, 8:17 PM
This revision was automatically updated to reflect the committed changes.

Feel free to counterdiff me if that blue is too intense.

ddd

src/applications/transactions/application/PhabricatorTransactionsApplication.php
36

llllddddd

OCram awarded a token.Dec 23 2015, 9:00 AM