Page MenuHomePhabricator

Put inline previews in remarkup textareas
ClosedPublic

Authored by epriestley on Dec 22 2015, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 9:57 PM
Unknown Object (File)
Mon, Dec 9, 1:12 PM
Unknown Object (File)
Mon, Dec 9, 12:55 AM
Unknown Object (File)
Fri, Dec 6, 11:08 AM
Unknown Object (File)
Fri, Dec 6, 10:54 AM
Unknown Object (File)
Thu, Dec 5, 12:03 AM
Unknown Object (File)
Sun, Dec 1, 7:25 PM
Unknown Object (File)
Sun, Dec 1, 7:25 PM
Subscribers
Tokens
"Love" token, awarded by OCram.

Details

Summary

Ref T3967. This gives us a reasonable baseline for doing remarkup previews inline in all contexts, and works in weird/constrained context including:

  • inline comments;
  • conpherence; and
  • custom fields.

It would be nicer to go beyond this in contexts like Phame posts, but this is a start, at least.

Test Plan

Screen Shot 2015-12-22 at 12.01.05 PM.png (1×1 px, 193 KB)

Screen Shot 2015-12-22 at 12.01.11 PM.png (1×1 px, 194 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Put inline previews in remarkup textareas.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2015, 8:17 PM
This revision was automatically updated to reflect the committed changes.

Feel free to counterdiff me if that blue is too intense.

ddd

src/applications/transactions/application/PhabricatorTransactionsApplication.php
36

llllddddd