Differential D14844

Add more NUX states
ClosedPublic
Actions

Authored by chad on Dec 21 2015, 7:09 PM.

Tags

None

Referenced Files

	F14477951: D14844.diff
	Sat, Dec 28, 3:59 PM

	Unknown Object (File)
	Wed, Dec 18, 9:46 PM

	Unknown Object (File)
	Wed, Dec 11, 1:25 PM

	Unknown Object (File)
	Sat, Dec 7, 11:32 AM

	Unknown Object (File)
	Sun, Dec 1, 7:25 PM

	Unknown Object (File)
	Sat, Nov 30, 6:41 PM

	Unknown Object (File)
	Fri, Nov 29, 2:17 AM

	Unknown Object (File)
	Nov 27 2024, 12:21 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T10032: Improve individual NUX states (application level)

Commits

Restricted Diffusion Commit
rP675be8efc526: Add more NUX states

Summary

Adds basic NUX to Dashboards, Herald, Repositories, Maniphest. Note Herald and Dashboard Panels don't fine the nux for some reason, assume they will when modernized?

Test Plan

Read text, click buttons.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35878.Dec 21 2015, 7:09 PM

chad retitled this revision from to Add more NUX states.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 21 2015, 7:09 PM

Yeah, I think Herald and Dashboards don't have the methods implemented that we need to do the "Are there any objects at all?" query, so we just default to non-nux.

src/applications/repository/query/PhabricatorRepositorySearchEngine.php
256	"just or browse" -> "or just browse"?

This revision is now accepted and ready to land.Dec 21 2015, 7:14 PM

(They'll get those methods the next time they get updated.)

Closed by commit rP675be8efc526: Add more NUX states (authored by chad, committed by chad). · Explain WhyDec 21 2015, 7:15 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T10032: Improve individual NUX states (application level).Dec 21 2015, 9:07 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

src/

applications/

dashboard/

controller/

PhabricatorDashboardPanelListController.php

19 lines

query/

PhabricatorDashboardSearchEngine.php

20 lines

herald/

application/

PhabricatorHeraldApplication.php

1 line

controller/

HeraldController.php

2 lines

query/

HeraldRuleSearchEngine.php

20 lines

maniphest/

query/

ManiphestTaskSearchEngine.php

20 lines

project/

query/

PhabricatorProjectSearchEngine.php

20 lines

repository/

query/

PhabricatorRepositorySearchEngine.php

27 lines

webroot/

rsrc/

css/

phui/

phui-big-info-view.css

8 lines

Diff 35879

resources/celerity/map.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php

Loading...

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

Loading...

src/applications/herald/application/PhabricatorHeraldApplication.php

Loading...

src/applications/herald/controller/HeraldController.php

Loading...

src/applications/herald/query/HeraldRuleSearchEngine.php

Loading...

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...

webroot/rsrc/css/phui/phui-big-info-view.css

Loading...