Page MenuHomePhabricator

Add more NUX states
ClosedPublic

Authored by chad on Dec 21 2015, 7:09 PM.

Details

Summary

Adds basic NUX to Dashboards, Herald, Repositories, Maniphest. Note Herald and Dashboard Panels don't fine the nux for some reason, assume they will when modernized?

Test Plan

Read text, click buttons.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 35878.Dec 21 2015, 7:09 PM
chad retitled this revision from to Add more NUX states.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley accepted this revision.Dec 21 2015, 7:14 PM
epriestley edited edge metadata.

Yeah, I think Herald and Dashboards don't have the methods implemented that we need to do the "Are there any objects at all?" query, so we just default to non-nux.

src/applications/repository/query/PhabricatorRepositorySearchEngine.php
256

"just or browse" -> "or just browse"?

This revision is now accepted and ready to land.Dec 21 2015, 7:14 PM

(They'll get those methods the next time they get updated.)

This revision was automatically updated to reflect the committed changes.