Page MenuHomePhabricator

Rename "SearchEngine" to "FulltextStorageEngine"
ClosedPublic

Authored by epriestley on Dec 21 2015, 6:29 PM.
Tags
None
Referenced Files
F11515720: D14843.diff
Tue, Jan 31, 3:07 AM
Unknown Object (File)
Dec 24 2022, 3:19 PM
Unknown Object (File)
Dec 14 2022, 5:44 AM
Unknown Object (File)
Dec 11 2022, 1:08 AM
Unknown Object (File)
Dec 11 2022, 1:08 AM
Unknown Object (File)
Dec 11 2022, 1:02 AM
Unknown Object (File)
Nov 23 2022, 8:58 AM
Unknown Object (File)
Nov 16 2022, 1:32 AM
Subscribers
None

Details

Summary

Ref T9979. I picked this name long before the advent of modern "Engine" architecture and it ended up being pretty confusing.

Rename "SearchEngine" (currently: mysql or elasticsearch, used to store and query fulltext indexes) to "FulltextStorageEngine" to make it more clear what it does and disambituate it from ApplicationSearch, which also has a bunch of stuff called "SearchEngine", "SearchEngineExtension", etc.

Test Plan

Grepped for phabricatorsearchengine.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Rename "SearchEngine" to "FulltextStorageEngine".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 8:32 PM
This revision was automatically updated to reflect the committed changes.