Page MenuHomePhabricator

Lift Conpherence indexing up out of the Fulltext index
ClosedPublic

Authored by epriestley on Dec 21 2015, 5:56 PM.
Tags
None
Referenced Files
F11531753: D14841.diff
Sun, Feb 5, 6:44 AM
Unknown Object (File)
Sun, Jan 29, 10:22 PM
Unknown Object (File)
Thu, Jan 26, 6:19 PM
Unknown Object (File)
Thu, Jan 19, 12:20 PM
Unknown Object (File)
Jan 5 2023, 3:26 PM
Unknown Object (File)
Dec 20 2022, 9:58 AM
Unknown Object (File)
Dec 15 2022, 2:57 PM
Unknown Object (File)
Dec 11 2022, 1:02 AM
Subscribers
None

Details

Summary

Ref T9979. There are currently some hacks around Conpherence indexing: it does not really use the fulltext index, but its own specialized index. However, it's kind of hacked up so it can get reindexed by the normal indexing pipeline.

Lift it up into IndexEngine, instead of FulltextEngine. Specifically, the new stuff is going to look like this:

  • IndexEngine: Rebuild all indexes.
    • ConpherenceIndexExtension: Rebuild thread indexes.
    • ProjectMemberIndexExtension: Rebuild project membership views.
    • NgramIndexExtension: Rebuild ngram indexes.
    • FulltextIndexExtension / FulltextEngine: Rebuild fulltext indexes, a special type of index.
      • FulltextCommentExtension: Rebuild comment fulltext indexes.
      • FulltextProjectExtension: Rebuild project fulltext indexes.
      • etc.

Most of this is at least sort-of-in-place as of this diff, although some of the part in the middle is still pretty rough.

Test Plan
  • Made a unique comment in a Conpherence thread.
  • Used bin/search index --force to rebuild the index.
  • Searched for the comment.
  • Found the thread.

Diff Detail

Repository
rP Phabricator
Branch
index5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9693
Build 11624: Run Core Tests
Build 11623: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Lift Conpherence indexing up out of the Fulltext index.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 6:27 PM
This revision was automatically updated to reflect the committed changes.