Page MenuHomePhabricator
Differential D14840

Add various NUX states
ClosedPublic
Actions

Authored by chad on Dec 21 2015, 5:12 PM.

Details

Reviewers
epriestley
Maniphest Tasks
T10032: Improve individual NUX states (application level)
Commits
Restricted Diffusion Commit
rPbde9ac43e71a: Add various NUX states
Summary

Adds basic NUX UI to Countdown, Paste, Phurl, Ponder, Slowvote, Macro, and Pholio.

Test Plan

Review each with ?nux=true. Click on Create Button.

Diff Detail

Repository
rP Phabricator
Branch
nux-3 (branched from master)
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 9689
Build 11619: Run Core Tests
Build 11618: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35872.Dec 21 2015, 5:12 PM
chad retitled this revision from to Add various NUX states.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 21 2015, 5:12 PM
epriestley accepted this revision.Dec 21 2015, 5:53 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/paste/query/PhabricatorPasteSearchEngine.php
219

Maybe "blocks of code" or "code snippets", "blocks of code snippets" reads a little oddly to me?

This revision is now accepted and ready to land.Dec 21 2015, 5:53 PM
Closed by commit rPbde9ac43e71a: Add various NUX states (authored by chad). · Explain WhyDec 21 2015, 5:55 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.
chad added a task: T10032: Improve individual NUX states (application level).Dec 21 2015, 9:07 PM

Revision Contents
Changeset List

PathSize
src/
applications/
countdown/
application/
2 lines
controller/
2 lines
query/
20 lines
macro/
query/
19 lines
paste/
query/
19 lines
pholio/
application/
3 lines
controller/
2 lines
query/
20 lines
phurl/
query/
19 lines
ponder/
query/
19 lines
slowvote/
query/
19 lines

Diff 35872

View Options

src/applications/countdown/application/PhabricatorCountdownApplication.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownController.php

Loading...
View Options

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...
View Options

src/applications/pholio/application/PhabricatorPholioApplication.php

Loading...
View Options

src/applications/pholio/controller/PholioController.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php

Loading...
View Options

src/applications/ponder/query/PonderQuestionSearchEngine.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
Phabricator · Built by Phacility