Page MenuHomePhabricator

Improve Conduit type handling for `*.edit` endpoints
ClosedPublic

Authored by epriestley on Dec 16 2015, 1:52 PM.
Tags
None
Referenced Files
F18675311: D14796.id35777.diff
Thu, Sep 25, 5:34 PM
F18657858: D14796.diff
Tue, Sep 23, 3:45 AM
F18607605: D14796.id35777.diff
Sun, Sep 14, 12:05 AM
F18506886: D14796.id.diff
Sep 5 2025, 1:51 AM
F18499603: D14796.diff
Sep 4 2025, 7:55 PM
F18392747: D14796.id.diff
Aug 29 2025, 8:32 AM
F18382064: D14796.diff
Aug 28 2025, 8:54 PM
F18087270: D14796.diff
Aug 6 2025, 3:16 AM
Subscribers

Details

Summary

Ref T9964. Three goals here:

  • Make it easier to supply Conduit documentation.
  • Make automatic documentation for *.edit endpoints more complete, particularly for custom fields.
  • Allow type resolution via Conduit types, so you can pass ["alincoln"] to "subscribers" instead of needing to use PHIDs.
Test Plan
  • Viewed and used all search and edit endpoints, including custom fields.
  • Used parameter type resolution to set subscribers to user "dog" instead of "PHID-USER-whatever".
  • Viewed HTTP parameter documentation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve Conduit type handling for `*.edit` endpoints.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2015, 4:34 PM
This revision was automatically updated to reflect the committed changes.
avivey added inline comments.
src/applications/conduit/parametertype/ConduitWildParameterType.php
4

Does this intentionally extends ListParameterType, or is it a typo (Doesn't support maps/objects...)?

Typo, a few things improperly extended List via copy/pasta errors. I think most of them have been cleaned up, but they're unintentional unless the subtype actually makes sense as a list subtype.

D15881 for last of these fixes, I think.