Differential D14789

Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in comment actions
ClosedPublic
Actions

Authored by epriestley on Dec 15 2015, 4:46 PM.

Tags

None

Referenced Files

	F14356884: D14789.diff
	Fri, Dec 20, 1:17 AM

	Unknown Object (File)
	Tue, Dec 17, 4:40 AM

	Unknown Object (File)
	Sun, Dec 15, 10:11 AM

	Unknown Object (File)
	Fri, Dec 13, 12:46 AM

	Unknown Object (File)
	Sat, Dec 7, 1:55 PM

	Unknown Object (File)
	Fri, Dec 6, 9:29 AM

	Unknown Object (File)
	Thu, Dec 5, 4:41 AM

	Unknown Object (File)
	Sun, Dec 1, 12:13 PM

Subscribers

None

Tokens

"Love" token, awarded by cburroughs.

Details

Reviewers

Maniphest Tasks

T6205: Replace "Associate Projects" action in task editing form with "Edit Projects"
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter

Commits

Restricted Diffusion Commit
rPd7693a93b3c4: Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in…

Summary

Ref T9908. Fixes T6205.

This is largely some refactoring to improve the code. The new structure is:

Each EditField has zero or one "submit" (normal edit form) controls.
Each EditField has zero or one "comment" (stacked actions) controls.
- If we want more than one in the future, we'd just add two fields.
Each EditField can have multiple EditTypes which provide Conduit transactions.
EditTypes are now lower-level and less involved on the Submit/Comment pathways.

Test Plan

Added and removed projects and subscribers.
Changed task statuses.
In two windows: added some subscribers in one, removed different ones in the other. The changes did not conflict.
Applied changes via Conduit.

Diff Detail

Repository

Branch

ee3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/transactions/editengine/PhabricatorEditEngine.php:1187	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 9579
Build 11452: Run Core Tests
Build 11451: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35761.Dec 15 2015, 4:46 PM

epriestley retitled this revision from to Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in comment actions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter, T6205: Replace "Associate Projects" action in task editing form with "Edit Projects".

cburroughs awarded a token.Dec 15 2015, 4:49 PM

If we want more than one in the future, we'd just add two fields.

This has some slightly weird implications, like if we wanted "Add Projects" and "Change Projects" for some reason we'd need to say that they're both bound to the locked/hidden status of whichever one gets a web UI control, but that's fairly reasonable and I'm pretty sure that will be very rare or wholly nonexistent anyway.

Fix some more initialValue vs originalValue consistency issues.

chad accepted this revision.Dec 15 2015, 9:01 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 15 2015, 9:01 PM

Closed by commit rPd7693a93b3c4: Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in… (authored by epriestley, committed by epriestley). · Explain WhyDec 15 2015, 11:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

20 lines

src/

__phutil_library_map__.php

6 lines

applications/

maniphest/

editor/

ManiphestEditEngine.php

4 lines

project/

engineextension/

PhabricatorProjectsEditEngineExtension.php

2 lines

subscriptions/

engineextension/

PhabricatorSubscriptionsEditEngineExtension.php

2 lines

transactions/

commentaction/

PhabricatorEditEngineCommentAction.php

49 lines

PhabricatorEditEngineSelectCommentAction.php

29 lines

PhabricatorEditEngineTokenizerCommentAction.php

55 lines

editengine/

PhabricatorEditEngine.php

113 lines

editfield/

PhabricatorCommentEditField.php

4 lines

PhabricatorEditField.php

129 lines

PhabricatorPHIDListEditField.php

8 lines

PhabricatorSelectEditField.php

35 lines

PhabricatorTokenizerEditField.php

52 lines

edittype/

PhabricatorEditType.php

12 lines

PhabricatorPHIDListEditType.php

59 lines

PhabricatorSimpleEditType.php

18 lines

view/

PhabricatorApplicationTransactionCommentView.php

83 lines

view/

form/

control/

AphrontFormTokenizerControl.php

16 lines

webroot/

rsrc/

js/

application/

transactions/

behavior-comment-actions.js

8 lines

Diff 35761

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...

src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php

Loading...

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsEditEngineExtension.php

Loading...

src/applications/transactions/commentaction/PhabricatorEditEngineCommentAction.php

Loading...

src/applications/transactions/commentaction/PhabricatorEditEngineSelectCommentAction.php

Loading...

src/applications/transactions/commentaction/PhabricatorEditEngineTokenizerCommentAction.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...

src/applications/transactions/editfield/PhabricatorCommentEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorPHIDListEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorSelectEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorTokenizerEditField.php

Loading...

src/applications/transactions/edittype/PhabricatorEditType.php

Loading...

src/applications/transactions/edittype/PhabricatorPHIDListEditType.php

Loading...

src/applications/transactions/edittype/PhabricatorSimpleEditType.php

Loading...

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...

src/view/form/control/AphrontFormTokenizerControl.php

Loading...

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...