Page MenuHomePhabricator

Clean up "*.search" API method documentation pages
ClosedPublic

Authored by epriestley on Dec 13 2015, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 2:03 AM
Unknown Object (File)
Tue, Mar 5, 2:02 AM
Unknown Object (File)
Tue, Mar 5, 2:02 AM
Unknown Object (File)
Tue, Mar 5, 2:02 AM
Unknown Object (File)
Tue, Mar 5, 2:02 AM
Unknown Object (File)
Feb 11 2024, 9:05 PM
Unknown Object (File)
Jan 26 2024, 9:57 AM
Unknown Object (File)
Jan 19 2024, 4:48 PM
Subscribers
None

Details

Summary

Ref T9964. Building tables in Remarkup is kind of neat-ish but ends up feeling kind of hacky, and requires weird workarounds if any of the values have | in them.

Switch to normal elements instead.

Also move the magic "ids" and "phids" to be more like real fields. I'll clean this up fully in a diff or two, it's just a little tricky because Maniphest has an "ids" field.

Test Plan

Screen Shot 2015-12-13 at 10.01.58 AM.png (641×948 px, 111 KB)

Diff Detail

Repository
rP Phabricator
Branch
nx10
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/search/engine/PhabricatorApplicationSearchEngine.php:1078XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9521
Build 11362: Run Core Tests
Build 11361: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Clean up "*.search" API method documentation pages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2015, 7:58 PM
This revision was automatically updated to reflect the committed changes.