Page MenuHomePhabricator

Modularize SearchEngine extensions
ClosedPublic

Authored by epriestley on Dec 13 2015, 1:29 PM.
Tags
None
Referenced Files
F18100117: D14764.id35719.diff
Sat, Aug 9, 11:10 AM
F18097197: D14764.id35697.diff
Fri, Aug 8, 11:44 AM
F18090925: D14764.id35718.diff
Wed, Aug 6, 6:10 PM
F18085469: D14764.id.diff
Tue, Aug 5, 7:15 PM
F18051927: D14764.id.diff
Mon, Aug 4, 12:44 AM
F17953870: D14764.id35718.diff
Aug 1 2025, 3:33 AM
F17949130: D14764.id35697.diff
Jul 31 2025, 10:53 PM
F17940297: D14764.diff
Jul 31 2025, 4:13 AM
Subscribers
None

Details

Summary

Ref T9964. ApplicationSearch currently has a bunch of hard-coded if ($object instanceof thing) stuff.

Pull that out so it can live in extensions.

Test Plan
  • Searched by spaces, subscribers, projects.

Screen Shot 2015-12-13 at 4.32.42 AM.png (956×1 px, 211 KB)

Diff Detail

Repository
rP Phabricator
Branch
nx6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9515
Build 11351: Run Core Tests
Build 11350: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize SearchEngine extensions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Dec 13 2015, 3:57 PM
epriestley edited edge metadata.
  • Clean tests.
This revision was automatically updated to reflect the committed changes.