Page MenuHomePhabricator
Differential D14764

Modularize SearchEngine extensions
ClosedPublic
Actions

Authored by epriestley on Dec 13 2015, 1:29 PM.
Tags
None
Referenced Files
F16417348: D14764.id35719.diff
Mon, Jun 16, 7:59 AM
Unknown Object (File)
Sun, Jun 15, 3:52 AM
Unknown Object (File)
Sun, May 25, 6:44 AM
Unknown Object (File)
May 10 2025, 3:08 AM
Unknown Object (File)
May 10 2025, 3:07 AM
Unknown Object (File)
May 10 2025, 3:07 AM
Unknown Object (File)
May 10 2025, 3:07 AM
Unknown Object (File)
May 8 2025, 8:08 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9964: Fill in Conduit support infrastructure for ApplicationEditor changes
Commits
Restricted Diffusion Commit
rP1b325a0a899a: Modularize SearchEngine extensions
Summary

Ref T9964. ApplicationSearch currently has a bunch of hard-coded if ($object instanceof thing) stuff.

Pull that out so it can live in extensions.

Test Plan
  • Searched by spaces, subscribers, projects.

Screen Shot 2015-12-13 at 4.32.42 AM.png (956×1 px, 211 KB)

Diff Detail

Repository
rP Phabricator
Branch
nx6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9515
Build 11351: Run Core Tests
Build 11350: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35697.Dec 13 2015, 1:29 PM
epriestley retitled this revision from to Modularize SearchEngine extensions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
chad accepted this revision.Dec 13 2015, 3:57 PM
chad edited edge metadata.

itsawesome

This revision is now accepted and ready to land.Dec 13 2015, 3:57 PM
epriestley updated this revision to Diff 35718.Dec 14 2015, 12:22 PM
epriestley edited edge metadata.
  • Clean tests.
Closed by commit rP1b325a0a899a: Modularize SearchEngine extensions (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2015, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35697

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectsEditEngineExtension.php

Loading...
View Options

src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php

Loading...
View Options

src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorSearchEngineExtension.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorSearchEngineExtensionModule.php

Loading...
View Options

src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php

Loading...
View Options

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditEngineExtension.php

Loading...
View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsEditEngineExtension.php

Loading...
View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsSearchEngineExtension.php

Loading...
View Options

src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php

Loading...
Phabricator · Built by Phacility