Page MenuHomePhabricator
Differential D14764

Modularize SearchEngine extensions
ClosedPublic
Actions

Authored by epriestley on Dec 13 2015, 1:29 PM.
Tags
None
Referenced Files
F18100117: D14764.id35719.diff
Sat, Aug 9, 11:10 AM
F18097197: D14764.id35697.diff
Fri, Aug 8, 11:44 AM
F18090925: D14764.id35718.diff
Wed, Aug 6, 6:10 PM
F18085469: D14764.id.diff
Tue, Aug 5, 7:15 PM
F18051927: D14764.id.diff
Mon, Aug 4, 12:44 AM
F17953870: D14764.id35718.diff
Fri, Aug 1, 3:33 AM
F17949130: D14764.id35697.diff
Thu, Jul 31, 10:53 PM
F17940297: D14764.diff
Thu, Jul 31, 4:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9964: Fill in Conduit support infrastructure for ApplicationEditor changes
Commits
Restricted Diffusion Commit
rP1b325a0a899a: Modularize SearchEngine extensions
Summary

Ref T9964. ApplicationSearch currently has a bunch of hard-coded if ($object instanceof thing) stuff.

Pull that out so it can live in extensions.

Test Plan
  • Searched by spaces, subscribers, projects.

Screen Shot 2015-12-13 at 4.32.42 AM.png (956×1 px, 211 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35697.Dec 13 2015, 1:29 PM
epriestley retitled this revision from to Modularize SearchEngine extensions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
chad accepted this revision.Dec 13 2015, 3:57 PM
chad edited edge metadata.

itsawesome

This revision is now accepted and ready to land.Dec 13 2015, 3:57 PM
epriestley updated this revision to Diff 35718.Dec 14 2015, 12:22 PM
epriestley edited edge metadata.
  • Clean tests.
Closed by commit rP1b325a0a899a: Modularize SearchEngine extensions (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2015, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35719

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectsEditEngineExtension.php

Loading...
View Options

src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php

Loading...
View Options

src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorSearchEngineExtension.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorSearchEngineExtensionModule.php

Loading...
View Options

src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php

Loading...
View Options

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditEngineExtension.php

Loading...
View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsEditEngineExtension.php

Loading...
View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsSearchEngineExtension.php

Loading...
View Options

src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php

Loading...
Phabricator · Built by Phacility