Differential D14763

Add basic typechecking support to Conduit
ClosedPublic
Actions

Authored by epriestley on Dec 13 2015, 12:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 3:14 PM

	Unknown Object (File)
	Sun, Apr 14, 1:51 AM

	Unknown Object (File)
	Fri, Apr 12, 12:47 PM

	Unknown Object (File)
	Fri, Apr 12, 12:47 PM

	Unknown Object (File)
	Thu, Apr 11, 7:22 AM

	Unknown Object (File)
	Tue, Apr 9, 7:42 PM

	Unknown Object (File)
	Thu, Mar 28, 2:41 PM

	Unknown Object (File)
	Mar 5 2024, 12:15 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T9964: Fill in Conduit support infrastructure for ApplicationEditor changes

Commits

Restricted Diffusion Commit
rP05a798e3ac68: Add basic typechecking support to Conduit

Summary

Ref T9964. I want to show users what we're expecting in "constraints", and let constraints like "authors=epriestley" work to make things easier.

I'm generally very happy with the "HTTPParameterType" stuff from EditEngine, so add a parallel set of "ConduitParameterType" classes. These are a little simpler than the HTTP ones, but have a little more validation logic.

Test Plan

This is really just a proof of concept; some of these fields are now filled in:

Screen Shot 2015-12-13 at 4.04.00 AM.png (316×618 px, 61 KB)

Diff Detail

Repository

Branch

nx5

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/conduit/parametertype/ConduitParameterType.php:62	XHP16	TODO Comment
Advice	src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php:163	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 9534
Build 11386: Run Core Tests
Build 11385: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35696.Dec 13 2015, 12:06 PM

epriestley retitled this revision from to Add basic typechecking support to Conduit.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

chad accepted this revision.Dec 13 2015, 3:27 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 13 2015, 3:27 PM

Clean tests.

Closed by commit rP05a798e3ac68: Add basic typechecking support to Conduit (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2015, 12:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

8 lines

applications/

conduit/

parametertype/

ConduitListParameterType.php

37 lines

ConduitParameterType.php

97 lines

ConduitStringListParameterType.php

40 lines

ConduitUserListParameterType.php

33 lines

protocol/

ConduitAPIRequest.php

4 lines

paste/

query/

PhabricatorPasteSearchEngine.php

1 line

people/

searchfield/

PhabricatorUsersSearchField.php

4 lines

search/

engine/

PhabricatorApplicationSearchEngine.php

42 lines

PhabricatorSearchEngineAPIMethod.php

16 lines

field/

PhabricatorSearchCheckboxesField.php

4 lines

PhabricatorSearchCustomFieldProxyField.php

2 lines

PhabricatorSearchField.php

81 lines

PhabricatorSearchStringListField.php

4 lines

Diff 35716

src/__phutil_library_map__.php

Loading...

src/applications/conduit/parametertype/ConduitListParameterType.php

Loading...

src/applications/conduit/parametertype/ConduitParameterType.php

Loading...

src/applications/conduit/parametertype/ConduitStringListParameterType.php

Loading...

src/applications/conduit/parametertype/ConduitUserListParameterType.php

Loading...

src/applications/conduit/protocol/ConduitAPIRequest.php

Loading...

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...

src/applications/people/searchfield/PhabricatorUsersSearchField.php

Loading...

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

Loading...

src/applications/search/field/PhabricatorSearchCheckboxesField.php

Loading...

src/applications/search/field/PhabricatorSearchCustomFieldProxyField.php

Loading...

src/applications/search/field/PhabricatorSearchField.php

Loading...

src/applications/search/field/PhabricatorSearchStringListField.php

Loading...