Page MenuHomePhabricator

Add basic typechecking support to Conduit

Authored by epriestley on Dec 13 2015, 12:06 PM.



Ref T9964. I want to show users what we're expecting in "constraints", and let constraints like "authors=epriestley" work to make things easier.

I'm generally very happy with the "HTTPParameterType" stuff from EditEngine, so add a parallel set of "ConduitParameterType" classes. These are a little simpler than the HTTP ones, but have a little more validation logic.

Test Plan

This is really just a proof of concept; some of these fields are now filled in:

Screen Shot 2015-12-13 at 4.04.00 AM.png (316×618 px, 61 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add basic typechecking support to Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2015, 3:27 PM
epriestley edited edge metadata.
  • Clean tests.
This revision was automatically updated to reflect the committed changes.