Paths

Table of Contentst

Differential D14756

Add Drafts to PhameHome
ClosedPublic
Actions

Authored by chad on Dec 12 2015, 9:04 PM.

Tags

None

Referenced Files

	F13135626: D14756.diff
	Thu, May 2, 9:51 AM

	Unknown Object (File)
	Mon, Apr 29, 2:30 AM

	Unknown Object (File)
	Sat, Apr 27, 8:33 AM

	Unknown Object (File)
	Thu, Apr 25, 6:58 PM

	Unknown Object (File)
	Thu, Apr 25, 6:58 PM

	Unknown Object (File)
	Thu, Apr 25, 1:22 AM

	Unknown Object (File)
	Tue, Apr 16, 4:55 AM

	Unknown Object (File)
	Fri, Apr 12, 8:24 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T9927: Improve PhameHome

Commits

Restricted Diffusion Commit
rP32a7674c22b9: Add Drafts to PhameHome

Summary

Adds a list of your drafts. Fixes T9927

Test Plan

Load up home, see my drafts. Fake 0 drafts, see fallback message.

pasted_file (464×309 px, 37 KB)

Diff Detail

Repository

Branch

phame-home-4 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9501
Build 11330: Run Core Tests
Build 11329: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35682.Dec 12 2015, 9:04 PM

chad retitled this revision from to Add Drafts to PhameHome.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 12 2015, 9:04 PM

chad edited the test plan for this revision. (Show Details)Dec 12 2015, 9:04 PM

epriestley accepted this revision.Dec 12 2015, 9:11 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/phame/controller/PhameHomeController.php
61	This should also have `withBloggerPHIDs(array($viewer->getPHID()))` or something, since otherwise we'll load everyone else's drafts and filter them really slowly in PHP. And probably just skip this completely if `!$viewer->isLoggedIn()` since logged-out users can't have drafts?

This revision is now accepted and ready to land.Dec 12 2015, 9:11 PM

updates to visibility

chad marked an inline comment as done.Dec 12 2015, 9:25 PM

Closed by commit rP32a7674c22b9: Add Drafts to PhameHome (authored by chad, committed by chad). · Explain WhyDec 12 2015, 9:26 PM

This revision was automatically updated to reflect the committed changes.

chad updated this object.Dec 12 2015, 9:33 PM

chad added a task: T9927: Improve PhameHome.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

phame/

controller/

PhameHomeController.php

14 lines

query/

PhamePostQuery.php

1 line

view/

PhameBlogListView.php

3 lines

	PhameDraftListView.php
	PhameBlogListView.php

38 lines

Diff 35682

src/__phutil_library_map__.php

Loading...

src/applications/phame/controller/PhameHomeController.php

Loading...

src/applications/phame/query/PhamePostQuery.php

Loading...

src/applications/phame/view/PhameBlogListView.php

Loading...

src/applications/phame/view/PhameDraftListView.php

Loading...