Read profile images from Google OAuth correctly
ClosedPublic
Actions

Authored by epriestley on Dec 12 2015, 3:52 PM.

Tags

None

Referenced Files

	F18702698: D14753.id35676.diff
	Sun, Sep 28, 1:02 AM

	F18684113: D14753.id.diff
	Fri, Sep 26, 8:42 AM

	F18665495: D14753.diff
	Sep 24 2025, 2:40 AM

	F18606359: D14753.diff
	Sep 13 2025, 10:11 PM

	F18588561: D14753.diff
	Sep 12 2025, 12:45 AM

	F18499551: D14753.diff
	Sep 4 2025, 7:51 PM

	F18170306: D14753.id35677.diff
	Aug 15 2025, 5:58 PM

	F18144267: D14753.id.diff
	Aug 14 2025, 2:59 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T9972: Profile image from Google not being picked up

Commits

rPHU4a09be9ffd4a: Read profile images from Google OAuth correctly

Summary

Fixes T9972. Not sure if this was always a bug or the API changed. There's also a "url" we can use now.

Test Plan

Refreshed a Google OAuth account link, got a profile picture:

Screen Shot 2015-12-12 at 7.50.22 AM.png (139×199 px, 20 KB)

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35676.Dec 12 2015, 3:52 PM

epriestley retitled this revision from to Read profile images from Google OAuth correctly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9972: Profile image from Google not being picked up.

chad accepted this revision.Dec 12 2015, 3:52 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 12 2015, 3:52 PM

Closed by commit rPHU4a09be9ffd4a: Read profile images from Google OAuth correctly (authored by epriestley, committed by epriestley). · Explain WhyDec 12 2015, 3:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

auth/

PhutilGoogleAuthAdapter.php

15 lines

Diff 35677

View Options

src/auth/PhutilGoogleAuthAdapter.php

Read profile images from Google OAuth correctlyClosedPublicActions