Page MenuHomePhabricator

Document how to customize forms in ApplicationEditor
ClosedPublic

Authored by epriestley on Dec 9 2015, 1:01 PM.
Tags
None
Referenced Files
F12848904: D14718.id.diff
Fri, Mar 29, 4:12 AM
F12842171: D14718.id.diff
Thu, Mar 28, 9:48 PM
Unknown Object (File)
Fri, Mar 22, 8:14 PM
Unknown Object (File)
Sat, Mar 16, 11:01 PM
Unknown Object (File)
Tue, Mar 5, 6:50 AM
Unknown Object (File)
Tue, Mar 5, 6:50 AM
Unknown Object (File)
Tue, Mar 5, 6:50 AM
Unknown Object (File)
Tue, Mar 5, 6:50 AM
Subscribers
None

Details

Summary

Ref T9132. I think the featureset is approximatley stable, so here's some documentation.

I also cleaned up a handful of things in the UI and tried to make them more obvious or more consistent.

Test Plan

Read documentation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Document how to customize forms in ApplicationEditor.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Add a little bit of language about how the upstream is using policies.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2015, 3:16 PM

That "Unmark as Edit Form" stuff in the UI doesn't feel great to me ("Unmark" is an odd action verb, particularly), but at least it's consistent now.

I think the feature set is approximately reasonable overall, although some of the UIs need a pass or two to polish them up and make them feel a little less clunky. Having them be a bit rough isn't awful since an administrator should only need to spend like 10 minutes in there once, but I have a few ideas to clean things up a little bit, at least.

This revision was automatically updated to reflect the committed changes.