Page MenuHomePhabricator
Differential D14713

Clean up URIs in Phame
ClosedPublic
Actions

Authored by chad on Dec 8 2015, 10:53 PM.
Tags
None
Referenced Files
F19555910: D14713.id.diff
Fri, Jan 30, 7:07 PM
F19554468: D14713.id35583.diff
Thu, Jan 29, 10:29 PM
F19510107: D14713.id35584.diff
Sun, Jan 11, 4:46 AM
F19350608: D14713.id35584.diff
Dec 26 2025, 3:32 AM
F19155107: D14713.id35583.diff
Dec 11 2025, 11:23 PM
F19087255: D14713.diff
Dec 3 2025, 12:09 AM
F19076309: D14713.id.diff
Dec 1 2025, 12:06 PM
F19069164: D14713.diff
Nov 30 2025, 1:10 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9897: Unbeta Feedback on Phame
Commits
Restricted Diffusion Commit
rPdafdd39ba9e8: Clean up URIs in Phame
Summary

Normalize "getViewURI" and "getLiveURI" for PhameBlog and PhamePost. Use pretty URIs in PhamePost

Test Plan

View Recent, View posts, edit post, new post, move post, view live.

Diff Detail

Repository
rP Phabricator
Branch
phame-pretty-urls
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9401
Build 11186: Run Core Tests
Build 11185: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35583.Dec 8 2015, 10:53 PM
chad retitled this revision from to Clean up URIs in Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 8 2015, 10:53 PM
epriestley accepted this revision.Dec 8 2015, 10:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2015, 10:54 PM
Closed by commit rPdafdd39ba9e8: Clean up URIs in Phame (authored by chad, committed by chad). · Explain WhyDec 8 2015, 10:55 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T9897: Unbeta Feedback on Phame.Dec 8 2015, 10:56 PM

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
application/
1 line
controller/
blog/
2 lines
post/
15 lines
11 lines
12 lines
query/
2 lines
storage/
7 lines
view/
2 lines

Diff 35583

View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogFeedController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostEditController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostNotLiveController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phame/query/PhamePostSearchEngine.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/phame/view/PhamePostListView.php

Loading...
Phabricator · Built by Phacility