Page MenuHomePhabricator

Remove "Create Empty Task" workflow callouts and some other clutter
ClosedPublic

Authored by epriestley on Dec 8 2015, 3:03 PM.

Details

Summary

Ref T9908. This removes the "Create Another Empty Task", "Create A Similar Task" and "Create Another Subtask of Same Parent Task" workflow callouts on the task detail page, which are actions that show up after creating a task or creating a subtask.

  • I think "Create Empty" isn't relevant now that we have "Create Task" nearby and the quick create menu?
  • I'm not sure if "Create Similar" is worth keeping. If we do want to retain it, I'd maybe like to find a way to do it generically.
  • I'm likewise not sure if "Create another subtask" is worth keeping.

Overall, these actions are weird/unusual and I'm not sure how valuable they are. I'm open to keeping "Similar" and/or "Subtask" but I'd like to verify that they're still valuable and make sure we have a reasonable design for them if we retain them.

For example, if we want to retain "Similar", maybe a better approach is just to add "Create Similar Object" to every action menu (which is now possible for EditEngine applications)? There's at least some interest in "Create Similar Repository" in Diffusion.

Also removes a very very old piece of "attached files" code.

Test Plan

Created and viewed some tasks.

Diff Detail

Repository
rP Phabricator
Branch
ex21
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/storage/ManiphestTask.php:45XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9381
Build 11155: Run Core Tests
Build 11154: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Remove "Create Empty Task" workflow callouts and some other clutter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I have a vague feeling people will miss this, but we can see how it plays out. My main concern is making "bulk task creation" quick if it's low cost.

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2015, 8:55 PM

We could put "Create Similar Task" next to "Create Subtask" as a possible half-step. I do think we'll get some pushback on getting rid of this, but I'm not sure how strong it will be.

I also briefly looked at reviving D8685 but that's way out of date and I don't feel great about clogging up the actions with a bunch of stuff, even if we hide some of it.

But maybe something like D8685 + fold "Revisions + Mocks" into a single item + fold "Create Subtask + Create Similar Task" into a single item is a possibility.

This revision was automatically updated to reflect the committed changes.