Differential D14704

Allow EditEngine create and edit forms to be reordered
ClosedPublic
Actions

Authored by epriestley on Dec 8 2015, 2:19 PM.

Details

Reviewers

chad

Maniphest Tasks

T9132: Build an ApplicationEditor abstraction
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter

Commits

Restricted Diffusion Commit
rP59ae0d6ffff8: Allow EditEngine create and edit forms to be reordered

Summary

Ref T9132. Ref T9908. Puts reordering UI in place:

For create forms, this just lets you pick a UI display order other than alphabetical. Seems nice to have.
For edit forms, this lets you create a hierarchy of advanced-to-basic forms and give them different visibility policies, if you want.

Test Plan

Screen Shot 2015-12-08 at 6.16.35 AM.png (1×1 px, 166 KB)

Verified that "Edit Thing" now takes me to the highest-ranked edit form.
Verified that create menu and quick create menu reflect application order.

Diff Detail

Repository

rP Phabricator

Branch

ex20

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/transactions/behavior-reorder-configs.js:1	JAVELIN5	`javelinsymbols` Not In Path
Advice	src/applications/transactions/editengine/PhabricatorEditEngine.php:1072	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 9380
Build 11153: Run Core Tests
Build 11152: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35563.Dec 8 2015, 2:19 PM

epriestley retitled this revision from to Allow EditEngine create and edit forms to be reordered.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter, T9132: Build an ApplicationEditor abstraction.

This also uses the viewer's default edit form when figuring out which actions are available from the "stacked actions" UI, so if they only have a basic edit form they only get the actions they could take with that form.

(They can still take all actions via Email Commands and Conduit and possibly Herald so this isn't really a policy enforcement on its own.)

chad accepted this revision.Dec 8 2015, 4:33 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 8 2015, 4:33 PM

Closed by commit rP59ae0d6ffff8: Allow EditEngine create and edit forms to be reordered (authored by epriestley, committed by epriestley). · Explain WhyDec 8 2015, 9:00 PM

This revision was automatically updated to reflect the committed changes.