Page MenuHomePhabricator

Allow EditEngine create and edit forms to be reordered
ClosedPublic

Authored by epriestley on Dec 8 2015, 2:19 PM.

Details

Summary

Ref T9132. Ref T9908. Puts reordering UI in place:

  • For create forms, this just lets you pick a UI display order other than alphabetical. Seems nice to have.
  • For edit forms, this lets you create a hierarchy of advanced-to-basic forms and give them different visibility policies, if you want.
Test Plan

Screen Shot 2015-12-08 at 6.16.35 AM.png (1×1 px, 166 KB)

  • Verified that "Edit Thing" now takes me to the highest-ranked edit form.
  • Verified that create menu and quick create menu reflect application order.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow EditEngine create and edit forms to be reordered.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

This also uses the viewer's default edit form when figuring out which actions are available from the "stacked actions" UI, so if they only have a basic edit form they only get the actions they could take with that form.

(They can still take all actions via Email Commands and Conduit and possibly Herald so this isn't really a policy enforcement on its own.)

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2015, 4:33 PM
This revision was automatically updated to reflect the committed changes.