Add unit tests for `AASTNode::getIndentation`
Needs ReviewPublic
Actions

Authored by joshuaspence on Dec 7 2015, 7:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 1, 7:35 AM

	Unknown Object (File)
	Sun, Dec 1, 7:05 AM

	Unknown Object (File)
	Wed, Nov 27, 4:39 AM

	Unknown Object (File)
	Sat, Nov 23, 6:20 PM

	Unknown Object (File)
	Sat, Nov 23, 12:10 AM

	Unknown Object (File)
	Tue, Nov 19, 10:37 AM

	Unknown Object (File)
	Fri, Nov 15, 10:44 AM

	Unknown Object (File)
	Tue, Nov 12, 9:26 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Adds some unit tests for D14107.

Test Plan

Unit tests pass... I probably need to make the test format a bit better though...

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9359
Build 11121: Run Core Tests
Build 11120: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35542.Dec 7 2015, 7:21 PM

joshuaspence retitled this revision from to Add unit tests for `AASTNode::getIndentation`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 7 2015, 7:21 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

src/

parser/

aast/

api/

AASTNode.php

2 lines

AASTTree.php

4 lines

xhpast/

api/

__tests__/

XHPASTNodeTestCase.php

26 lines

indentation/

class.php.test

28 lines

Diff 35542

View Options

src/parser/aast/api/AASTNode.php

View Options

src/parser/aast/api/AASTTree.php

View Options

src/parser/xhpast/api/tests/XHPASTNodeTestCase.php

View Options

src/parser/xhpast/api/tests/indentation/class.php.test

Add unit tests for `AASTNode::getIndentation`Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35542

src/parser/aast/api/AASTNode.php

src/parser/aast/api/AASTTree.php

src/parser/xhpast/api/__tests__/XHPASTNodeTestCase.php

src/parser/xhpast/api/__tests__/indentation/class.php.test

Add unit tests for `AASTNode::getIndentation`
Needs ReviewPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/api/tests/XHPASTNodeTestCase.php

src/parser/xhpast/api/tests/indentation/class.php.test