Page MenuHomePhabricator

Clean up some EditEngine policy issues
ClosedPublic

Authored by epriestley on Dec 7 2015, 6:37 PM.

Details

Summary

Ref T9908.

  • You should not need edit permission on a task in order to comment on it.
  • At least for now, ignore any customization in Conduit and Stacked Actions. These UIs always use the full edit form as it's written in the application.
Test Plan
  • Verified a non-editor can now comment on tasks they can see.
  • Verified a user still can't use an edit form they can't see.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Clean up some EditEngine policy issues.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 7 2015, 7:03 PM
This revision was automatically updated to reflect the committed changes.