Differential D14673

Swap "Create Task" button over to EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 4 2015, 10:19 PM.

Tags

None

Referenced Files

	F15521130: D14673.id35483.diff
	Sun, Apr 20, 11:24 AM

	F15520318: D14673.id.diff
	Sun, Apr 20, 5:32 AM

	F15425556: D14673.id35494.diff
	Mar 23 2025, 4:54 AM

	F15409006: D14673.diff
	Mar 19 2025, 2:42 AM

	F15387135: D14673.id35494.diff
	Mar 15 2025, 1:54 AM

	F15379867: D14673.diff
	Mar 13 2025, 11:48 PM

	Unknown Object (File)
	Feb 21 2025, 4:02 AM

	Unknown Object (File)
	Feb 19 2025, 5:30 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T9132: Build an ApplicationEditor abstraction

Commits

Restricted Diffusion Commit
rP7aa865db2ddf: Swap "Create Task" button over to EditEngine

Summary

Ref T9132. I can't actually get rid of the EditController yet since a few weird things still use it, but I think I can swap this button out without breaking anything. This will let us do "New Feature Request" / "New Bug" / "Advanced Task Creation" on secure and start playing with this stuff sooner.

Test Plan

Clicked "Create Task", got sent to new form.

Diff Detail

Repository

Branch

ee43

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9294
Build 11034: Run Core Tests
Build 11033: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35483.Dec 4 2015, 10:19 PM

epriestley retitled this revision from to Swap "Create Task" button over to EditEngine.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9132: Build an ApplicationEditor abstraction.

chad accepted this revision.Dec 4 2015, 10:47 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 4 2015, 10:47 PM

Closed by commit rP7aa865db2ddf: Swap "Create Task" button over to EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 12:31 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestController.php

8 lines

Diff 35483

src/applications/maniphest/controller/ManiphestController.php

Loading...