Page MenuHomePhabricator
Differential D14664

Make "Add Action..." add actions at the bottom instead of the top
ClosedPublic
Actions

Authored by epriestley on Dec 4 2015, 3:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 3:56 AM
Unknown Object (File)
Mon, Apr 29, 4:05 PM
Unknown Object (File)
Sun, Apr 28, 12:57 AM
Unknown Object (File)
Wed, Apr 24, 11:53 PM
Unknown Object (File)
Tue, Apr 23, 10:09 PM
Unknown Object (File)
Mon, Apr 22, 5:42 AM
Unknown Object (File)
Fri, Apr 19, 3:53 PM
Unknown Object (File)
Sun, Apr 14, 2:56 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9132: Build an ApplicationEditor abstraction
Commits
Restricted Diffusion Commit
rP8bbea6d41c92: Make "Add Action..." add actions at the bottom instead of the top
Summary

Ref T9132. Shhh this never happened shhhhhhh.

Test Plan

Selected multiple actions, saw them add at the bottom.

Diff Detail

Repository
rP Phabricator
Branch
ee36
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9281
Build 11010: Run Core Tests
Build 11009: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35470.Dec 4 2015, 3:00 PM
epriestley retitled this revision from to Make "Add Action..." add actions at the bottom instead of the top.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9132: Build an ApplicationEditor abstraction.
chad accepted this revision.Dec 4 2015, 3:01 PM
chad edited edge metadata.

:|

This revision is now accepted and ready to land.Dec 4 2015, 3:01 PM
epriestley added a comment.Dec 4 2015, 3:02 PM

Did you like the top-add behavior? I'm fine with retaining it, this is mostly just me trying to pretend I didn't write the "grotesque" code.

epriestley added a comment.Dec 4 2015, 3:03 PM

(Top-add feels fairly weird to me, but I don't mind experimenting with stuff here and it's a one-line change.)

Closed by commit rP8bbea6d41c92: Make "Add Action..." add actions at the bottom instead of the top (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 12:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
20 lines
src/
applications/
transactions/
view/
11 lines
webroot/
rsrc/
js/
application/
transactions/
8 lines

Diff 35470

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...
Phabricator · Built by Phacility