Page MenuHomePhabricator
Differential D14658

Separate out PhameDescriptionView
ClosedPublic
Actions

Authored by chad on Dec 3 2015, 10:29 PM.
Tags
None
Referenced Files
F18085409: D14658.diff
Tue, Aug 5, 7:12 PM
F18055470: D14658.id35457.diff
Mon, Aug 4, 7:33 AM
F17949290: D14658.diff
Thu, Jul 31, 11:10 PM
F17936705: D14658.id.diff
Thu, Jul 31, 12:31 AM
F17913626: D14658.diff
Tue, Jul 29, 6:09 PM
F17912332: D14658.diff
Tue, Jul 29, 4:05 PM
Unknown Object (File)
Jun 28 2025, 3:21 PM
Unknown Object (File)
Jun 7 2025, 11:31 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9897: Unbeta Feedback on Phame
Commits
Restricted Diffusion Commit
rP7ce2ad294ff8: Separate out PhameDescriptionView
Summary

Make this function re-usable in other views. Ref T9897

Test Plan

View a blog, see the same information

Diff Detail

Repository
rP Phabricator
Branch
phame-descriptions
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9268
Build 10991: Run Core Tests
Build 10990: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35457.Dec 3 2015, 10:29 PM
chad retitled this revision from to Separate out PhameDescriptionView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9897: Unbeta Feedback on Phame.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 3 2015, 10:29 PM
epriestley accepted this revision.Dec 3 2015, 10:32 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 3 2015, 10:32 PM
Closed by commit rP7ce2ad294ff8: Separate out PhameDescriptionView (authored by chad, committed by chad). · Explain WhyDec 3 2015, 10:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
phame/
controller/
blog/
58 lines
view/
60 lines

Diff 35457

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

Loading...
View Options

src/applications/phame/view/PhameDescriptionView.php

Loading...
Phabricator · Built by Phacility