Page MenuHomePhabricator
Differential D14656

Fix Phame Post creation time
ClosedPublic
Actions

Authored by chad on Dec 3 2015, 9:40 PM.
Tags
None
Referenced Files
F14054713: D14656.id35453.diff
Sat, Nov 16, 4:14 AM
F14029060: D14656.diff
Fri, Nov 8, 7:07 PM
F14012028: D14656.diff
Fri, Nov 1, 6:58 AM
F14002791: D14656.id35453.diff
Fri, Oct 25, 10:31 PM
F13985434: D14656.id.diff
Sun, Oct 20, 8:29 PM
Unknown Object (File)
Oct 9 2024, 2:44 AM
Unknown Object (File)
Sep 12 2024, 8:15 AM
Unknown Object (File)
Sep 7 2024, 12:21 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9897: Unbeta Feedback on Phame
T9360: Unbeta Phame
Commits
Restricted Diffusion Commit
rP39903769f063: Fix Phame Post creation time
Summary

I spent way to long to arrive at this solution. Ref T9360

Test Plan

Publish a new post, see time, unpublish post, see draft. Start a new post, wait 10 minutes, publish, see "now".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35453.Dec 3 2015, 9:40 PM
chad retitled this revision from to Fix Phame Post creation time.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 3 2015, 9:40 PM
epriestley accepted this revision.Dec 3 2015, 9:42 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/storage/PhamePost.php
37

For consistency, prefer PhabricatorTime::getNow() (which allows unit tests to force the "current time" to some specific known time).

This revision is now accepted and ready to land.Dec 3 2015, 9:42 PM
chad updated this object.Dec 3 2015, 9:42 PM
chad edited edge metadata.
chad added a task: T9360: Unbeta Phame.
Closed by commit rP39903769f063: Fix Phame Post creation time (authored by chad, committed by chad). · Explain WhyDec 3 2015, 9:43 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T9897: Unbeta Feedback on Phame.Dec 3 2015, 9:44 PM

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
controller/
post/
2 lines
editor/
2 lines
storage/
2 lines

Diff 35454

View Options

src/applications/phame/controller/post/PhamePostEditController.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
Phabricator · Built by Phacility