Page MenuHomePhabricator
Differential D14649

Remove `asp_tags` from XHPAST
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 10:44 PM.
Tags
None
Referenced Files
F14026318: D14649.diff
Fri, Nov 8, 12:58 AM
F13978982: D14649.diff
Sat, Oct 19, 1:56 AM
F13974990: D14649.id.diff
Fri, Oct 18, 8:15 AM
F13974988: D14649.id35434.diff
Fri, Oct 18, 8:14 AM
F13974803: D14649.id35529.diff
Fri, Oct 18, 7:26 AM
F13970881: D14649.diff
Thu, Oct 17, 10:20 AM
F13958912: D14649.id.diff
Mon, Oct 14, 4:59 PM
Unknown Object (File)
Sun, Oct 13, 8:58 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU9380454298b0: Remove `asp_tags` from XHPAST
Summary

This is hardcoded to false anyway.

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35434.Dec 2 2015, 10:44 PM
joshuaspence retitled this revision from to Remove `asp_tags` from XHPAST.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 10:44 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence mentioned this in D14537: Tidying of XHPAST.Dec 2 2015, 10:46 PM
epriestley accepted this revision.Dec 5 2015, 12:25 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2015, 12:25 AM
Closed by commit rPHU9380454298b0: Remove `asp_tags` from XHPAST (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 7 2015, 10:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
bin/
2 lines
support/
xhpast/
2 lines
22 lines
2 lines
1542 lines
3 lines

Diff 35529

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/ast.hpp

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility