Page MenuHomePhabricator
Differential D14641

Add a linter rule for public properties
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 11:32 PM
Unknown Object (File)
Fri, Nov 15, 3:06 PM
Unknown Object (File)
Sun, Nov 10, 11:50 PM
Unknown Object (File)
Sun, Nov 10, 6:38 PM
Unknown Object (File)
Wed, Nov 6, 7:01 PM
Unknown Object (File)
Oct 19 2024, 7:06 AM
Unknown Object (File)
Oct 9 2024, 2:44 AM
Unknown Object (File)
Oct 2 2024, 3:17 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCcdaad096fa8d: Add a linter rule for public properties
Summary

Add a linter rule which advises against public class properties.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35419.Dec 2 2015, 9:06 PM
joshuaspence retitled this revision from to Add a linter rule for public properties.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 9:06 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 2 2015, 9:11 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistPublicPropertyXHPASTLinterRule.php
29–30

Maybe "getter and setter methods" or "a getter and setter" vs "a getter and setter methods".

This revision is now accepted and ready to land.Dec 2 2015, 9:11 PM
joshuaspence updated this revision to Diff 35438.Dec 2 2015, 10:52 PM
joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.

Fix text

Closed by commit rARCcdaad096fa8d: Add a linter rule for public properties (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 10:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35439

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistPublicPropertyXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPublicPropertyXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/public-property/class.lint-test

Loading...
Phabricator · Built by Phacility