Differential D14641

Add a linter rule for public properties
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 9:06 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCcdaad096fa8d: Add a linter rule for public properties

Summary

Add a linter rule which advises against public class properties.

Test Plan

Added unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35419.Dec 2 2015, 9:06 PM

joshuaspence retitled this revision from to Add a linter rule for public properties.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 9:06 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 2 2015, 9:11 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/lint/linter/xhpast/rules/ArcanistPublicPropertyXHPASTLinterRule.php
29–30	Maybe "getter and setter methods" or "a getter and setter" vs "a getter and setter methods".

This revision is now accepted and ready to land.Dec 2 2015, 9:11 PM

Fix text

Closed by commit rARCcdaad096fa8d: Add a linter rule for public properties (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 10:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

xhpast/

ArcanistXHPASTLinterRule.php

1 line

rules/

ArcanistPublicPropertyXHPASTLinterRule.php

35 lines

__tests__/

ArcanistPublicPropertyXHPASTLinterRuleTestCase.php

10 lines

public-property/

class.lint-test

9 lines

Diff 35439

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistPublicPropertyXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistPublicPropertyXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/public-property/class.lint-test

Add a linter rule for public propertiesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35439

src/__phutil_library_map__.php

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistPublicPropertyXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistPublicPropertyXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/public-property/class.lint-test

Add a linter rule for public properties
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/xhpast/rules/tests/ArcanistPublicPropertyXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/public-property/class.lint-test