Page MenuHomePhabricator

Consolidate transaction generation in EditType objects
ClosedPublic

Authored by epriestley on Nov 30 2015, 4:39 PM.
Tags
None
Referenced Files
F13136682: D14607.diff
Thu, May 2, 3:05 PM
Unknown Object (File)
Wed, Apr 24, 10:51 PM
Unknown Object (File)
Thu, Apr 11, 7:43 AM
Unknown Object (File)
Tue, Apr 9, 12:40 AM
Unknown Object (File)
Mar 27 2024, 10:30 PM
Unknown Object (File)
Mar 5 2024, 4:08 AM
Unknown Object (File)
Mar 5 2024, 4:08 AM
Unknown Object (File)
Mar 5 2024, 4:08 AM
Subscribers
None

Details

Summary

Ref T9132. This is a bit more cleanup to make adding CustomField support easier.

Right now, both EditField and EditType can actually generate a transaction. This doesn't matter too much in practice today, but gets a little more complicated a couple of diffs from now with CustomField stuff.

Instead, always use EditType to generate the transaction. In the future, this should give us less total code and make more things work cleanly by default.

Test Plan

Used web UI and Conduit to make various edits to pastes, including doing race-condition tests on "Projects".

Diff Detail

Repository
rP Phabricator
Branch
ee25
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9143
Build 10792: Run Core Tests
Build 10791: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Consolidate transaction generation in EditType objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 4:42 PM
This revision was automatically updated to reflect the committed changes.