Page MenuHomePhabricator

Consolidate transaction generation in EditType objects
ClosedPublic

Authored by epriestley on Nov 30 2015, 4:39 PM.
Tags
None
Referenced Files
F14058332: D14607.diff
Sun, Nov 17, 11:01 AM
F14026750: D14607.id35339.diff
Fri, Nov 8, 2:02 AM
F14026749: D14607.id35332.diff
Fri, Nov 8, 2:02 AM
F14026747: D14607.id.diff
Fri, Nov 8, 2:02 AM
F14026746: D14607.diff
Fri, Nov 8, 2:02 AM
F14011780: D14607.diff
Fri, Nov 1, 5:15 AM
F13989371: D14607.id35339.diff
Mon, Oct 21, 8:00 PM
F13974652: D14607.id.diff
Oct 18 2024, 6:36 AM
Subscribers
None

Details

Summary

Ref T9132. This is a bit more cleanup to make adding CustomField support easier.

Right now, both EditField and EditType can actually generate a transaction. This doesn't matter too much in practice today, but gets a little more complicated a couple of diffs from now with CustomField stuff.

Instead, always use EditType to generate the transaction. In the future, this should give us less total code and make more things work cleanly by default.

Test Plan

Used web UI and Conduit to make various edits to pastes, including doing race-condition tests on "Projects".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Consolidate transaction generation in EditType objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 4:42 PM
This revision was automatically updated to reflect the committed changes.