Page MenuHomePhabricator

Modernize Transaction value controller, fixing logged-out policy issue
ClosedPublic

Authored by epriestley on Nov 30 2015, 2:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 2, 4:42 AM
Unknown Object (File)
Tue, Aug 2, 4:42 AM
Unknown Object (File)
Tue, Aug 2, 4:42 AM
Unknown Object (File)
Tue, Aug 2, 4:42 AM
Unknown Object (File)
Thu, Jul 28, 4:27 AM
Unknown Object (File)
Mon, Jul 25, 9:00 PM
Unknown Object (File)
Sun, Jul 10, 7:13 AM
Unknown Object (File)
Jul 6 2022, 9:24 AM
Subscribers
None

Details

Summary

Fixes T9869. This specific transaction endpoint was missing shouldAllowPublic(). Also modernize things a little.

Test Plan

Viewed a policy change by clicking the policy name from the transaction record on a public object while logged out.

Diff Detail

Repository
rP Phabricator
Branch
policyvalue
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9138
Build 10786: Run Core Tests
Build 10785: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modernize Transaction value controller, fixing logged-out policy issue.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 2:55 PM
This revision was automatically updated to reflect the committed changes.