Modernize Transaction value controller, fixing logged-out policy issue
ClosedPublic
Actions

Authored by epriestley on Nov 30 2015, 2:52 PM.

Details

Reviewers

chad

Maniphest Tasks

T9869: Certain transactions not viewable while logged out?

Commits

Restricted Diffusion Commit
rPb35f578ae915: Modernize Transaction value controller, fixing logged-out policy issue

Summary

Fixes T9869. This specific transaction endpoint was missing shouldAllowPublic(). Also modernize things a little.

Test Plan

Viewed a policy change by clicking the policy name from the transaction record on a public object while logged out.

Diff Detail

Repository

rP Phabricator

Branch

policyvalue

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9138
Build 10786: Run Core Tests
Build 10785: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35327.Nov 30 2015, 2:52 PM

epriestley retitled this revision from to Modernize Transaction value controller, fixing logged-out policy issue.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9869: Certain transactions not viewable while logged out?.

chad accepted this revision.Nov 30 2015, 2:55 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 30 2015, 2:55 PM

Closed by commit rPb35f578ae915: Modernize Transaction value controller, fixing logged-out policy issue (authored by epriestley, committed by epriestley). · Explain WhyNov 30 2015, 2:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

controller/

PhabricatorApplicationTransactionValueController.php

28 lines

Diff 35327

View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php

Modernize Transaction value controller, fixing logged-out policy issueClosedPublicActions