Page MenuHomePhabricator
Differential D14604

Add a linter rule for invalid octals
ClosedPublic
Actions

Authored by joshuaspence on Nov 30 2015, 11:35 AM.
Tags
None
Referenced Files
F14026732: D14604.id35423.diff
Fri, Nov 8, 2:01 AM
F14026730: D14604.id35422.diff
Fri, Nov 8, 2:00 AM
F14026728: D14604.id35346.diff
Fri, Nov 8, 2:00 AM
F14026727: D14604.id35324.diff
Fri, Nov 8, 2:00 AM
F14026725: D14604.id.diff
Fri, Nov 8, 2:00 AM
F14026724: D14604.diff
Fri, Nov 8, 2:00 AM
F14022072: D14604.diff
Wed, Nov 6, 3:09 PM
F14018098: D14604.id.diff
Tue, Nov 5, 4:38 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC560e4ae4919b: Add a linter rule for invalid octals
Summary

PHP doesn't handle octals very well. Basically, it seems that any numeric scalar matching /^0\d+$/ will be treated as an octal, whereas this should be /^0[0-7]+$/. As a result, 08 and 09 are both treated as 0 (because they are invalid octals. This diff adds a linter rule to detect this abnormality.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35324.Nov 30 2015, 11:35 AM
joshuaspence retitled this revision from to Add a linter rule for invalid numerals.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 11:35 AM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence updated this revision to Diff 35346.Nov 30 2015, 7:32 PM
joshuaspence edited edge metadata.

With tests

epriestley accepted this revision.Nov 30 2015, 7:35 PM
epriestley added a reviewer: epriestley.
epriestley added inline comments.
src/lint/linter/xhpast/rules/__tests__/invalid-octal-numeric-scalar/octal.lint-test
4–5

Maybe include these test cases?

0
0.9
0xFf
0XFf
0b01
-08
This revision is now accepted and ready to land.Nov 30 2015, 7:35 PM
joshuaspence updated this revision to Diff 35422.Dec 2 2015, 9:24 PM
joshuaspence edited edge metadata.

Moar tests

Herald added a subscriber: Korvin. · View Herald TranscriptDec 2 2015, 9:24 PM
joshuaspence retitled this revision from Add a linter rule for invalid numerals to Add a linter rule for invalid octals.Dec 2 2015, 9:25 PM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence marked an inline comment as done.
joshuaspence removed a subscriber: Korvin.
Closed by commit rARC560e4ae4919b: Add a linter rule for invalid octals (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 9:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35423

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistInvalidOctalNumericScalarXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInvalidOctalNumericScalarXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/invalid-octal-numeric-scalar/binary.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/invalid-octal-numeric-scalar/decimal.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/invalid-octal-numeric-scalar/hexadecimal.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/invalid-octal-numeric-scalar/octal.lint-test

Loading...
Phabricator · Built by Phacility