Page MenuHomePhabricator
Differential D14602

Add a linter rule for variable reference spacing
ClosedPublic
Actions

Authored by joshuaspence on Nov 30 2015, 11:15 AM.
Tags
None
Referenced Files
F19536185: D14602.id35349.diff
Wed, Jan 21, 10:33 AM
F18757055: D14602.diff
Oct 5 2025, 3:21 PM
F18702393: D14602.id35322.diff
Sep 27 2025, 11:58 PM
F18670862: D14602.id35350.diff
Sep 25 2025, 1:51 AM
F18596687: D14602.diff
Sep 13 2025, 1:15 AM
F18594123: D14602.id35349.diff
Sep 12 2025, 5:04 PM
F18593036: D14602.diff
Sep 12 2025, 1:45 PM
F18085374: D14602.id.diff
Aug 5 2025, 7:11 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC87306cfe1453: Add a linter rule for variable reference spacing
Summary

Adds a linter rule for spacing after the & token, similar to ArcanistUnaryPrefixExpressionSpacingXHPASTLinterRule.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35322.Nov 30 2015, 11:15 AM
joshuaspence retitled this revision from to Add a linter rule for variable reference spacing.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 11:15 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 30 2015, 1:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 1:08 PM
joshuaspence updated this revision to Diff 35349.Nov 30 2015, 8:21 PM
joshuaspence edited edge metadata.

Minor tidying

Closed by commit rARC87306cfe1453: Add a linter rule for variable reference spacing (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 30 2015, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35350

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistVariableReferenceSpacingXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistVariableReferenceSpacingXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/variable-reference-spacing/function-call.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/variable-reference-spacing/variable.lint-test

Loading...
Phabricator · Built by Phacility