Paths

Table of Contentst

Differential D14600

Allow EditEngine Conduit endpoints to accept object IDs and monograms
ClosedPublic
Actions

Authored by epriestley on Nov 29 2015, 7:30 PM.

Details

Reviewers

chad

Maniphest Tasks

T9132: Build an ApplicationEditor abstraction

Commits

Restricted Diffusion Commit
rP50f257adee18: Allow EditEngine Conduit endpoints to accept object IDs and monograms

Summary

Ref T9132. This is a quality-of-life improvement for new application.edit endpoints.

Instead of strictly requiring PHIDs, allow IDs or monograms. This primarily makes these endpoints easier to test and use.

Test Plan

Edited objects via API by passing IDs, PHIDs and monograms.

Diff Detail

Repository

rP Phabricator

Branch

eengine23

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9123
Build 10760: Run Core Tests
Build 10759: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35311.Nov 29 2015, 7:30 PM

epriestley retitled this revision from to Allow EditEngine Conduit endpoints to accept object IDs and monograms.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9132: Build an ApplicationEditor abstraction.

Small cleanup.

chad accepted this revision.Nov 30 2015, 3:08 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 30 2015, 3:08 PM

Closed by commit rP50f257adee18: Allow EditEngine Conduit endpoints to accept object IDs and monograms (authored by epriestley, committed by epriestley). · Explain WhyNov 30 2015, 5:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

86 lines

PhabricatorEditEngineAPIMethod.php

10 lines

Diff 35312

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php